-
-
Notifications
You must be signed in to change notification settings - Fork 358
chore(deps): v8: update Cocoa SDK to v9.3.0 #5515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6aa223+dirty | 543.40 ms | 564.24 ms | 20.84 ms |
| 206e87e+dirty | 464.80 ms | 504.68 ms | 39.88 ms |
| bc8a1ed+dirty | 442.18 ms | 476.27 ms | 34.08 ms |
| b4fa5b4+dirty | 449.55 ms | 481.50 ms | 31.95 ms |
| 12fba4a+dirty | 483.60 ms | 514.49 ms | 30.89 ms |
| fa0d109+dirty | 429.60 ms | 452.50 ms | 22.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6aa223+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
| 206e87e+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
| bc8a1ed+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| b4fa5b4+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 12fba4a+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
| fa0d109+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6aa223+dirty | 436.98 ms | 466.42 ms | 29.44 ms |
| 206e87e+dirty | 416.94 ms | 440.98 ms | 24.04 ms |
| bc8a1ed+dirty | 396.10 ms | 426.80 ms | 30.69 ms |
| b4fa5b4+dirty | 382.09 ms | 398.28 ms | 16.19 ms |
| 12fba4a+dirty | 456.57 ms | 462.90 ms | 6.32 ms |
| fa0d109+dirty | 413.71 ms | 434.22 ms | 20.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6aa223+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| 206e87e+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
| bc8a1ed+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| b4fa5b4+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| 12fba4a+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
| fa0d109+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
# Conflicts: # packages/core/RNSentry.podspec
…5451) * chore(deps): update Cocoa SDK to v9.0.0-alpha.0 * Adds changelog * fix: Fixes SentryScreenFrames use after being converted to Swift (#5153) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build --------- Co-authored-by: Antonis Lilis <[email protected]> * Move `sentry-cocoa` `enableLogs` out of experimental (#5267) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests --------- Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Antonis Lilis <[email protected]> * chore: Remove SentryFrameTracker imports (#5276) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper --------- Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: Denis Andrasec <[email protected]> Co-authored-by: Noah Martin <[email protected]> * fix(podspec): Cocoa V9 allow any alpha version * chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 (#5359) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 --------- Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Denis Andrasec <[email protected]> Co-authored-by: Noah Martin <[email protected]> * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 (#5369) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 * Bump to 15.1 due to RN 0.81.0 requirements --------- Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Itay Brenner <[email protected]> Co-authored-by: Denis Andrasec <[email protected]> Co-authored-by: Noah Martin <[email protected]> * chore(ci): Cocoa V9: Run the full CI checks for cocoa-v9 (#5370) * Update changelog * Bumpt to RC1 * Remove cocoa-v9 from ci branches * fix: Use new session replay name for hybrid SDK * Fix rename * chore(lint): Fixes lint issues * Update changelog to GA * chore: Move from using Hybrid SDK subspec to regular Sentry podspec * Update changelog * Bump minimum to 9.1.0 * Replace SentryOptionsInternal with PrivateSentrySDKOnly helper method * Replace the deprecated `optionsWithDictionary` with `options(with:)` * Added RNSentry+formatters.h * Do not use subspec * Fix lint issues * Remove Unused import * Fix build issue * Add header search paths --------- Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: Noah Martin <[email protected]> Co-authored-by: Philipp Hofmann <[email protected]>
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 206e87e+dirty | 1197.12 ms | 1204.25 ms | 7.13 ms |
| b4fa5b4+dirty | 1213.59 ms | 1211.26 ms | -2.33 ms |
| d6aa223+dirty | 1216.76 ms | 1213.40 ms | -3.37 ms |
| 12fba4a+dirty | 1209.43 ms | 1217.08 ms | 7.65 ms |
| bc8a1ed+dirty | 1198.66 ms | 1200.60 ms | 1.94 ms |
| fa0d109+dirty | 1206.81 ms | 1205.38 ms | -1.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 206e87e+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| b4fa5b4+dirty | 3.44 MiB | 4.66 MiB | 1.22 MiB |
| d6aa223+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| 12fba4a+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| bc8a1ed+dirty | 3.44 MiB | 4.66 MiB | 1.22 MiB |
| fa0d109+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 206e87e+dirty | 1184.11 ms | 1183.19 ms | -0.92 ms |
| b4fa5b4+dirty | 1203.83 ms | 1207.13 ms | 3.30 ms |
| d6aa223+dirty | 1192.33 ms | 1208.17 ms | 15.84 ms |
| 12fba4a+dirty | 1214.20 ms | 1223.30 ms | 9.09 ms |
| bc8a1ed+dirty | 1194.70 ms | 1201.18 ms | 6.48 ms |
| fa0d109+dirty | 1216.02 ms | 1220.67 ms | 4.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 206e87e+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| b4fa5b4+dirty | 3.44 MiB | 4.66 MiB | 1.22 MiB |
| d6aa223+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| 12fba4a+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| bc8a1ed+dirty | 3.44 MiB | 4.66 MiB | 1.22 MiB |
| fa0d109+dirty | 3.38 MiB | 4.67 MiB | 1.29 MiB |
| @@ -0,0 +1,35 @@ | |||
| #import <Foundation/Foundation.h> | |||
|
|
|||
| // This file is a copy from | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: do we use this? why copy it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @lucas-zimerman 👍
it was actually added with e1d97f3 in #5451
I think it is not needed now though. I removed it with 0f1f386. Let's see if the CI is happy 🤞
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📢 Type of change
Based on #5501
📜 Description
💡 Motivation and Context
Fixes #5598
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps